[commit] r1588 - in trunk/GME/XmlBackEnd: . SVNCode

[GMESRC Repository Notifications]

Author: ksmyth
Date: Tue Oct  4 18:03:40 2011
New Revision: 1588

Log:
FIXME, TODO

Modified:
   trunk/GME/XmlBackEnd/CoreXmlFile.cpp
   trunk/GME/XmlBackEnd/SVNCode/Path.cpp

Modified: trunk/GME/XmlBackEnd/CoreXmlFile.cpp
==============================================================================
--- trunk/GME/XmlBackEnd/CoreXmlFile.cpp	Tue Oct  4 18:03:28 2011	(r1587)
+++ trunk/GME/XmlBackEnd/CoreXmlFile.cpp	Tue Oct  4 18:03:40 2011	(r1588)
@@ -3399,6 +3399,7 @@
 		// add to source control if not added yet
 		try
 		{
+			// TODO: a good candidate for another thread
 			addToSourceControl( container, f_existed );
 		}
 		catch(...)
@@ -4114,6 +4115,7 @@
 		{
 			sc_add = addSVN( fileName);
 			sc_pro = lockablePropertySVN( fileName);
+			// TODO: use svn_client_propset_local to add locking to all the files
 		}
 		
 		if( !m_userOpts.m_useBulkCommit)                         // if bulk commit then avoid individual commits
@@ -5643,6 +5645,7 @@
 				continue; // file exists, is read-only, means no lock on it
 
 			// unlock one file at a time
+			// FIXME: fails for newly-added files when the commit fails
 			bool succ = m_svn->unLock(fileName);
 			if(!succ)
 				AfxMessageBox( "Commit/Unlock pair failed");

Modified: trunk/GME/XmlBackEnd/SVNCode/Path.cpp
==============================================================================
--- trunk/GME/XmlBackEnd/SVNCode/Path.cpp	Tue Oct  4 18:03:28 2011	(r1587)
+++ trunk/GME/XmlBackEnd/SVNCode/Path.cpp	Tue Oct  4 18:03:40 2011	(r1588)
@@ -78,6 +78,12 @@
 	}
 	else
 	{
+		// FIXME: hits the disk a lot
+		//21	XmlBackEnd.dll	Util::preprocessPath + 0xf0, c:\users\ksmyth\git\gmesrc\gme\xmlbackend\svncode\util.cpp(317)	0x6f9f4a0	C:\Users\ksmyth\git\GMESRC\GME\Release\XmlBackEnd.dll
+		//22	XmlBackEnd.dll	Path::Path + 0x6d, c:\users\ksmyth\git\gmesrc\gme\xmlbackend\svncode\path.cpp(39)	0x6f9b82d	C:\Users\ksmyth\git\GMESRC\GME\Release\XmlBackEnd.dll
+		//23	XmlBackEnd.dll	Client::sub_propertySet + 0xb5, c:\users\ksmyth\git\gmesrc\gme\xmlbackend\svncode\client.cpp(357)	0x6f97945	C:\Users\ksmyth\git\GMESRC\GME\Release\XmlBackEnd.dll
+		//24	XmlBackEnd.dll	HiClient::lockableProp + 0xd8, c:\users\ksmyth\git\gmesrc\gme\xmlbackend\svncode\hiclient.cpp(320)	0x6f98cc8	C:\Users\ksmyth\git\GMESRC\GME\Release\XmlBackEnd.dll
+
 		m_error_occured = Util::preprocessPath(pi_path, m_pool);
 
 		m_path = pi_path;