[commit] r1900 - in trunk: GME/Console GME/Gme GME/MgaDecorators Install

[GMESRC Repository Notifications]

Author: ksmyth
Date: Tue Apr 17 16:37:29 2012
New Revision: 1900

Log:
TODOs and FIXMEs

Modified:
   trunk/GME/Console/ConsoleCtl.cpp
   trunk/GME/Gme/GMEApp.cpp
   trunk/GME/MgaDecorators/BoxDecoratorImpl.cpp
   trunk/Install/GME_paradigms.wxs

Modified: trunk/GME/Console/ConsoleCtl.cpp
==============================================================================
--- trunk/GME/Console/ConsoleCtl.cpp	Tue Apr 17 16:37:14 2012	(r1899)
+++ trunk/GME/Console/ConsoleCtl.cpp	Tue Apr 17 16:37:29 2012	(r1900)
@@ -594,6 +594,7 @@
 			CComPtr<IHTMLElement> pElement;
 			COMTHROW(pHtmlDoc->get_body( &pElement ));
 			ASSERT(pElement != NULL);
+			// FIXME: under wine, access violation in ieframe.dll
 			COMTHROW(pElement->get_innerHTML(&contents));
 		}
 		catch (hresult_exception &)

Modified: trunk/GME/Gme/GMEApp.cpp
==============================================================================
--- trunk/GME/Gme/GMEApp.cpp	Tue Apr 17 16:37:14 2012	(r1899)
+++ trunk/GME/Gme/GMEApp.cpp	Tue Apr 17 16:37:29 2012	(r1900)
@@ -1553,6 +1553,7 @@
 				CString errmsg = _T("Could not save project: ");
 				errmsg += error;
 				if (hr == HRESULT_FROM_WIN32(ERROR_ACCESS_DENIED)) {
+					// FIXME: KMS: not too sure why this is ACCESS_DENIED from MoveFile instead of SHARING_VIOLATION
 					errmsg += _T("\nCheck that no other GME has this file open");
 				}
 				AfxMessageBox(errmsg);

Modified: trunk/GME/MgaDecorators/BoxDecoratorImpl.cpp
==============================================================================
--- trunk/GME/MgaDecorators/BoxDecoratorImpl.cpp	Tue Apr 17 16:37:14 2012	(r1899)
+++ trunk/GME/MgaDecorators/BoxDecoratorImpl.cpp	Tue Apr 17 16:37:29 2012	(r1900)
@@ -302,6 +302,7 @@
 	catch(DecoratorException& e) {
 		retVal = e.GetHResult();
 	}
+	// TODO: catch bad_alloc et al
 
 	return retVal;
 }

Modified: trunk/Install/GME_paradigms.wxs
==============================================================================
--- trunk/Install/GME_paradigms.wxs	Tue Apr 17 16:37:14 2012	(r1899)
+++ trunk/Install/GME_paradigms.wxs	Tue Apr 17 16:37:29 2012	(r1900)
@@ -16,7 +16,7 @@
     <PropertyRef Id="NETFRAMEWORK20"/>
     <PropertyRef Id="NETFRAMEWORK40FULL"/>
     <PropertyRef Id="NETFRAMEWORK40CLIENT"/>
-    <Property Id="NETFRAMEWORK">NETFRAMEWORK20 OR NETFRAMEWORK40FULL OR NETFRAMEWORK40CLIENT</Property>
+    <Property Id="NETFRAMEWORK">NETFRAMEWORK20 OR NETFRAMEWORK40FULL OR NETFRAMEWORK40CLIENT</Property><!-- FIXME: doesnt work -->
 
     <!-- =========================================================== -->
     <!-- DIRECTORY STRUCTURE -->