[commit] r1859 - trunk/GME/PartBrowser

[GMESRC Repository Notifications]

Author: ksmyth
Date: Fri Mar  9 16:30:00 2012
New Revision: 1859

Log:
FIXMEs

Modified:
   trunk/GME/PartBrowser/PartBrowserDlg.cpp
   trunk/GME/PartBrowser/PartBrowserPane.cpp

Modified: trunk/GME/PartBrowser/PartBrowserDlg.cpp
==============================================================================
--- trunk/GME/PartBrowser/PartBrowserDlg.cpp	Fri Mar  9 16:29:50 2012	(r1858)
+++ trunk/GME/PartBrowser/PartBrowserDlg.cpp	Fri Mar  9 16:30:00 2012	(r1859)
@@ -45,6 +45,7 @@
 
 void CPartBrowserDlg::SetMetaModel(CComPtr<IMgaMetaModel> meta)
 {
+	// FIXME: check if mgaMetaModel == meta
 	if (mgaMetaModel != NULL)
 		mgaMetaModel.Release();
 	mgaMetaModel = meta;

Modified: trunk/GME/PartBrowser/PartBrowserPane.cpp
==============================================================================
--- trunk/GME/PartBrowser/PartBrowserPane.cpp	Fri Mar  9 16:29:50 2012	(r1858)
+++ trunk/GME/PartBrowser/PartBrowserPane.cpp	Fri Mar  9 16:30:00 2012	(r1859)
@@ -323,7 +323,9 @@
 	mgaMetaModel = meta;
 
 	DestroyDecorators();
-	// Store parts and crate & initialize decorators
+	// Store parts and create & initialize decorators
+	// FIXME: don't do this if PartBrowser is not displayed, it is expensive
+	// FIXME: lazily instantiate when aspect is changed
 	if (meta) {
 		CComPtr<IMgaMetaAspects> mmAspects;
 		COMTHROW(mgaMetaModel->get_Aspects(&mmAspects));