[commit] r2169 - trunk/GME/Core

GMESRC Repository Notifications gme-commit at list.isis.vanderbilt.edu
Wed Apr 10 08:46:31 CDT 2013


Author: ksmyth
Date: Wed Apr 10 08:46:31 2013
New Revision: 2169

Log:
Fail fast with empty mga file

Modified:
   trunk/GME/Core/CoreBinFile.h

Modified: trunk/GME/Core/CoreBinFile.h
==============================================================================
--- trunk/GME/Core/CoreBinFile.h	Wed Apr 10 08:46:09 2013	(r2168)
+++ trunk/GME/Core/CoreBinFile.h	Wed Apr 10 08:46:31 2013	(r2169)
@@ -25,6 +25,10 @@
 		if (hFile == INVALID_HANDLE_VALUE) {
 			return 1;
 		}
+		DWORD filesize = GetFileSize(hFile, NULL);
+		if (filesize == INVALID_FILE_SIZE || filesize == 0) {
+			return 1;
+		}
 		hFileMappingObject = CreateFileMapping(hFile, NULL, PAGE_READONLY, 0, 0, NULL);
 		if (hFileMappingObject == INVALID_HANDLE_VALUE) {
 			return 1;
@@ -33,10 +37,6 @@
 		if (begin == NULL) {
 			return 1;
 		}
-		DWORD filesize = GetFileSize(hFile, NULL);
-		if (filesize == INVALID_FILE_SIZE) {
-			return 1;
-		}
 		end = begin + filesize;
 		return 0;
 	}


More information about the gme-commit mailing list