[commit] r2600 - trunk/GME/Gme

GMESRC Repository Notifications gme-commit at list.isis.vanderbilt.edu
Mon Jun 1 10:58:07 CDT 2015


Author: ksmyth
Date: Mon Jun  1 10:58:07 2015
New Revision: 2600

Log:
Fix model grid position for FCOs with position 0x7FFFFFFF (or thereabouts). Works, but technically lots of UB with unsigned overflow elsewhere

Modified:
   trunk/GME/Gme/ModelGrid.cpp

Modified: trunk/GME/Gme/ModelGrid.cpp
==============================================================================
--- trunk/GME/Gme/ModelGrid.cpp	Mon May 18 16:25:33 2015	(r2599)
+++ trunk/GME/Gme/ModelGrid.cpp	Mon Jun  1 10:58:07 2015	(r2600)
@@ -119,7 +119,7 @@
 bool CModelGrid::IsAvailable(const CRect& rect)
 {
 	FindStartEnd(rect,0);
-	if(startx < 0 || starty < 0 || endx >= GME_MAX_GRID_DIM || endy >= GME_MAX_GRID_DIM)
+	if(startx < 0 || starty < 0 || (unsigned int)endx >= GME_MAX_GRID_DIM || (unsigned int)endy >= GME_MAX_GRID_DIM)
 		return false;
 	for(int y = starty; y <= endy; y++)
 		for(int x = startx; x <= endx; x++)


More information about the gme-commit mailing list