[commit] r2724 - in trunk/GME: MgaUtil PartBrowser

GMESRC Repository Notifications gme-commit at list.isis.vanderbilt.edu
Wed Dec 6 13:41:40 CST 2017


Author: ksmyth
Date: Wed Dec  6 13:41:40 2017
New Revision: 2724

Log:
Fix uninitialized reads

Modified:
   trunk/GME/MgaUtil/MgaResolver.cpp
   trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp

Modified: trunk/GME/MgaUtil/MgaResolver.cpp
==============================================================================
--- trunk/GME/MgaUtil/MgaResolver.cpp	Wed Dec  6 13:41:37 2017	(r2723)
+++ trunk/GME/MgaUtil/MgaResolver.cpp	Wed Dec  6 13:41:40 2017	(r2724)
@@ -1003,7 +1003,7 @@
 					return RESOLV_ERR_get_RoleByStr;
 				}
 
-				INT_PTR dlgResult;
+				INT_PTR dlgResult = IDOK;
 				if ((cdl.m_sz_prelist.GetCount() != 0) 
 					&& 
 					((dlgResult = cdl.DoModal()) == IDOK) 

Modified: trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp
==============================================================================
--- trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp	Wed Dec  6 13:41:37 2017	(r2723)
+++ trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp	Wed Dec  6 13:41:40 2017	(r2724)
@@ -22,7 +22,8 @@
 	lineSize (20),
 	pageSize (60),
     pageHeight(100), // maybe fix UNINITIALIZED READ: reading register edx PartBrowser.OCX!CPartBrowserPaneFrame::Resize [c:\users\kevin\documents\gme\gme\partbrowser\partbrowserpaneframe.cpp:57]
-    logicalHeight(100)
+    logicalHeight(100),
+    scrollPos(0)
 {
 	//{{AFX_DATA_INIT(CPartBrowserPaneFrame)
 		// NOTE: the ClassWizard will add member initialization here


More information about the gme-commit mailing list