[commit] r2785 - in trunk/GME: Console ConstraintManager Core GMEActiveBrowser Gme Meta Mga ObjectInspector PanningView Parser PartBrowser Search XmlBackEnd
GMESRC Repository Notifications
gme-commit at list.isis.vanderbilt.edu
Tue Apr 7 10:44:34 CDT 2020
Author: ksmyth
Date: Tue Apr 7 10:44:34 2020
New Revision: 2785
Log:
Enable compiler warning C4189: unused initialized local variable, associated fixes
Modified:
trunk/GME/Console/Console.vcxproj
trunk/GME/Console/ScriptEdit.cpp
trunk/GME/ConstraintManager/ConstraintManager.vcxproj
trunk/GME/Core/Core.vcxproj
trunk/GME/Core/CoreBinFile.cpp
trunk/GME/GMEActiveBrowser/GMEActiveBrowser.vcxproj
trunk/GME/Gme/GME.vcxproj
trunk/GME/Meta/Meta.vcxproj
trunk/GME/Meta/MetaUtilities.cpp
trunk/GME/Mga/Mga.vcxproj
trunk/GME/ObjectInspector/ObjectInspector.vcxproj
trunk/GME/PanningView/PanningView.vcxproj
trunk/GME/Parser/Parser.vcxproj
trunk/GME/PartBrowser/PartBrowser.vcxproj
trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp
trunk/GME/Search/Search.vcxproj
trunk/GME/XmlBackEnd/XmlBackEnd.vcxproj
Modified: trunk/GME/Console/Console.vcxproj
==============================================================================
--- trunk/GME/Console/Console.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Console/Console.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -189,6 +189,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Console/ScriptEdit.cpp
==============================================================================
--- trunk/GME/Console/ScriptEdit.cpp Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Console/ScriptEdit.cpp Tue Apr 7 10:44:34 2020 (r2785)
@@ -241,7 +241,6 @@
_bstr_t eng;
COMTHROW(registrar->get_ScriptEngine(REGACCESS_USER, eng.GetAddress()));
_bstr_t engine(L"JScript");
- int len = eng.length();
if (eng.length() != 0)
engine = eng;
Modified: trunk/GME/ConstraintManager/ConstraintManager.vcxproj
==============================================================================
--- trunk/GME/ConstraintManager/ConstraintManager.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/ConstraintManager/ConstraintManager.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -173,6 +173,7 @@
<FunctionLevelLinking>true</FunctionLevelLinking>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Core/Core.vcxproj
==============================================================================
--- trunk/GME/Core/Core.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Core/Core.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -281,6 +281,9 @@
<DataExecutionPrevention>
</DataExecutionPrevention>
</Link>
+ <ClCompile>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
+ </ClCompile>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<CustomBuildStep />
Modified: trunk/GME/Core/CoreBinFile.cpp
==============================================================================
--- trunk/GME/Core/CoreBinFile.cpp Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Core/CoreBinFile.cpp Tue Apr 7 10:44:34 2020 (r2785)
@@ -147,8 +147,6 @@
void BinObject::HasGuidAndStatAttributes(GUID& t_guid, bool* p_statusFound, bool* p_oldRegFound)
{
- int a1( 0), a2( 0), a3( 0), a4( 0);
-
binattrs_iterator i = binattrs.begin();
binattrs_iterator e = binattrs.end();
while( i != e)
Modified: trunk/GME/GMEActiveBrowser/GMEActiveBrowser.vcxproj
==============================================================================
--- trunk/GME/GMEActiveBrowser/GMEActiveBrowser.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/GMEActiveBrowser/GMEActiveBrowser.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -118,6 +118,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Gme/GME.vcxproj
==============================================================================
--- trunk/GME/Gme/GME.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Gme/GME.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -127,6 +127,7 @@
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
<PrecompiledHeader>Use</PrecompiledHeader>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Meta/Meta.vcxproj
==============================================================================
--- trunk/GME/Meta/Meta.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Meta/Meta.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -263,6 +263,7 @@
<ClCompile>
<PreprocessorDefinitions>NDEBUG;WIN32;_WINDOWS;_USRDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PrecompiledHeader>Use</PrecompiledHeader>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Meta/MetaUtilities.cpp
==============================================================================
--- trunk/GME/Meta/MetaUtilities.cpp Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Meta/MetaUtilities.cpp Tue Apr 7 10:44:34 2020 (r2785)
@@ -380,7 +380,6 @@
}
if( nmspc && nmspc.Length() > 0) // some namespace is set
{
- bool nm_match = false;
COMTHROW(nmspc.Append( L"::"));
unsigned int nms_len = nmspc.Length();
unsigned int pin_len = pIn.Length();
Modified: trunk/GME/Mga/Mga.vcxproj
==============================================================================
--- trunk/GME/Mga/Mga.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Mga/Mga.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -215,6 +215,9 @@
</DataExecutionPrevention>
<TargetMachine>MachineX86</TargetMachine>
</Link>
+ <ClCompile>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
+ </ClCompile>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release_PGO_Optimize|Win32'">
<CustomBuildStep />
Modified: trunk/GME/ObjectInspector/ObjectInspector.vcxproj
==============================================================================
--- trunk/GME/ObjectInspector/ObjectInspector.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/ObjectInspector/ObjectInspector.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -118,6 +118,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/PanningView/PanningView.vcxproj
==============================================================================
--- trunk/GME/PanningView/PanningView.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/PanningView/PanningView.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -169,6 +169,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/Parser/Parser.vcxproj
==============================================================================
--- trunk/GME/Parser/Parser.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Parser/Parser.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -113,6 +113,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/PartBrowser/PartBrowser.vcxproj
==============================================================================
--- trunk/GME/PartBrowser/PartBrowser.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/PartBrowser/PartBrowser.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -175,6 +175,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp
==============================================================================
--- trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/PartBrowser/PartBrowserPaneFrame.cpp Tue Apr 7 10:44:34 2020 (r2785)
@@ -129,9 +129,11 @@
RECT r;
GetClientRect(&r);
BOOL success = pane.Create(NULL, _T("PartsPane"), WS_CHILD | WS_VISIBLE | WS_BORDER, r, this, IDD_PARTBROWSER_PANE);
- pane.ModifyStyleEx(0, WS_EX_CLIENTEDGE);
+ if (success) {
+ pane.ModifyStyleEx(0, WS_EX_CLIENTEDGE);
+ }
- return TRUE; // return TRUE unless you set the focus to a control
+ return success; // return TRUE unless you set the focus to a control
// EXCEPTION: OCX Property Pages should return FALSE
}
Modified: trunk/GME/Search/Search.vcxproj
==============================================================================
--- trunk/GME/Search/Search.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/Search/Search.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -177,6 +177,7 @@
<PrecompiledHeader>Use</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Modified: trunk/GME/XmlBackEnd/XmlBackEnd.vcxproj
==============================================================================
--- trunk/GME/XmlBackEnd/XmlBackEnd.vcxproj Tue Apr 7 10:44:29 2020 (r2784)
+++ trunk/GME/XmlBackEnd/XmlBackEnd.vcxproj Tue Apr 7 10:44:34 2020 (r2785)
@@ -199,6 +199,7 @@
</PrecompiledHeader>
<WarningLevel>Level3</WarningLevel>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+ <AdditionalOptions>/w34189 %(AdditionalOptions)</AdditionalOptions>
</ClCompile>
<ResourceCompile>
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
More information about the gme-commit
mailing list