[tao-users] change request / enhancement of RTCORBA thread pool

[Johnny Willemsen]

Hi,

> * You right, we could just  remove the "_array" suffix from methods name, by calling them: " dynamic_threads_" and "static_threads_". 
> However, we have to avoid the confusion with the other two already existing methods called: " CORBA::ULong static_threads (void) const" and " CORBA::ULong dynamic_threads (void) const" which are dealing with the number of threads.

I see it, it is better then to add the array, having _ as last is not nice.

> * You don't need to add methods in the header file, they already could be reached in the "inline" (.inl) file.

That is not true, depends on whether inlining is enabled or not

> * Please find in attachment, an example based on "Messenger" of the required feature that consists in setting the thread affinity.

Please create a pull request where you make the code change and add the
new unit test including adding it to the test suite.

Best regards,

Johnny

> 
> Regards,
> Jean-Louis
> 
> [@@THALES GROUP RESTRICTED@@]
> 
> 
> -----Message d'origine-----
> De : Johnny Willemsen [mailto:jwillemsen at remedy.nl] 
> Envoyé : mercredi 20 janvier 2016 15:47
> À : GILBERT Jean-Louis; 'tao-users at list.isis.vanderbilt.edu'
> Objet : Re: [tao-users] change request / enhancement of RTCORBA thread pool
> 
> Hi,
> 
> Thanks for using the PRF form. Shouldn't there be new methods in the header and why add _array to the operations? Could you also adapt one of the RTCORBA unit tests or add a new one to demonstrate how these methods should be used?
> 
> Independent of that, for additions please create a github pull request, see https://github.com/DOCGroup/ATCD/
> 
> Best regards,
> 
> Johnny Willemsen
> Remedy IT Expertise BV
> Postbus 81 | 6930 AB Westervoort | The Netherlands http://www.remedy.nl
> 
> On 01/20/2016 03:41 PM, GILBERT Jean-Louis wrote:
>> *PRF change request / enhancement of RTCORBA thread pool*
>>
>>  
>>
>> *   ACE VERSION: 6.3.0 – TAO VERSION: 2.3.0*
>>
>> * *
>>
>> *    HOST MACHINE and OPERATING SYSTEM: Linux-Redhat 5(RHEL5)*
>>
>> *        *
>>
>> *    TARGET MACHINE and OPERATING SYSTEM, if different from HOST: N/A*
>>
>> * *
>>
>> *    COMPILER NAME AND VERSION (AND PATCHLEVEL): gcc-4.2*
>>
>>  
>>
>>    
>>
>>     *AREA/CLASS/EXAMPLE AFFECTED*: RTCORBA/TAO_Thread_Lane
>>
>>        
>>
>>        
>>
>>     *SYNOPSIS*:
>>
>>         The modification will permit to obtain static and dynamic 
>> threads pool in a public way, in /TAO_Thread_Lane/ class(/File 
>> TAO/tao/RTCORBA/Thread_Pool.in)./
>>
>> Our objective is to modify thread affinity of tasks in RTCORBA features.
>>
>>  
>>
>>  
>>
>>  
>>
>>     *DESCRIPTION*:
>>
>>  
>>
>> Here are the following public methods to add the file: 
>> /Thread_Pool.inl./
>>
>>  
>>
>> */ACE_INLINE/*
>>
>> */  TAO_Thread_Pool_Threads &/*
>>
>> */  TAO_Thread_Lane::static_threads_array (void)/*
>>
>> */  {/*
>>
>> */          return this->static_threads_;/*
>>
>> */  }/*
>>
>> */ /*
>>
>> */ /*
>>
>> */ACE_INLINE/*
>>
>> */  TAO_Dynamic_Thread_Pool_Threads &/*
>>
>> */  TAO_Thread_Lane::dynamic_threads_array (void)/*
>>
>> */  {/*
>>
>> */          return this->dynamic_threads_;/*
>>
>> */  }/*
>>
>>  
>>
>> This doesn’t affect regression tests.
>>
>>  
>>
>>     REPEAT BY: N/A
>>
>>  
>>
>>     SAMPLE FIX/WORKAROUND: N/A
>>
>>  
>>
>> Thanks in advance for your reply.
>>
>>  
>>
>> Regards,
>>
>> Jean-Louis GILBERT
>>
>>  
>>
>> [@@THALES GROUP RESTRICTED@@]
>>
>>  
>>
>>
>>
>> _______________________________________________
>> tao-users mailing list
>> tao-users at list.isis.vanderbilt.edu
>> http://list.isis.vanderbilt.edu/cgi-bin/mailman/listinfo/tao-users
>>